bors-servo
a2368a0614
Fix core-text related warnings (#62) ### Fix private-in-public warnings (error E0446) Fixed by prepending `pub` to the offending types. Not sure if its the best way but it was the only thing that worked. Other methods I've tried to maintain privateness: * Replace with an empty enum. That threw an error. * Make it public and wrap within a private module. That threw an error too as `#[repr(C)]` does not accept modules ### Fix use of extern static warnings by wrapping in unsafe block (error E0133) I think this is self-explanatory. ### Fix zero-size struct warnings on certain CT* types Wrap around c_void as I believe the types are only used as pointers. Again, let me know if there is a better way to do this. I've tried following [this discussion](https://github.com/rust-lang/rust/issues/27303) on opaque C types but I don't think there is a consensus. I came across this [discussion](https://github.com/AngryLawyer/rust-sdl2/issues/442) from the Rust SDL2 bindings and they eventually [opted](https://github.com/AngryLawyer/rust-sdl2/pull/445) for the solution that I implemented. This is my first pull request (hence, first open source contribution) and I've been playing with Rust for the past few weeks. So please, if anything isnt up to standards or correctness, let me know! Also, to squash the other warnings, those changes would have to made in the modules where those types reside (core-graphics and core-foundation). I would gladly open a PR to fix those too if all looks good. Thanks! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/65) <!-- Reviewable:end -->
core-text-rs
