yuqei/wycheproof
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LSC: Delete uses of goog.isDefAndNotNull, goog.isDef, goog.isNull, goog.isString, goog.isBoolean, and goog.isNumber.

Browse Source 
These functions are all trivial one-liners that inline to clearer code that is nearly as small (and in some cases even smaller) than the function call.

See go/lsc-goog-isdef

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:263067138:BASE:263057012:1565671265213:a988ea45
NOKEYCHECK=True
PiperOrigin-RevId: 263257614
GitOrigin-RevId: b9879442a887349646d064825c5c86ce904ab6f9
This commit is contained in:
Wycheproof Team
2019-08-13 18:13:03 -07:00
committed by Tink Team
parent 3bab7ff533
commit 2f40e86f93
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
javascript/BigInteger.js
+2 -2
View File
@@ -70,7 +70,7 @@ wycheproof.BigInteger.fromHex = function(s) {
*/
wycheproof.BigInteger.prototype.toBase64Url = function(optValue) {
var bytes = this.toByteArray();
if (goog.isDef(optValue) && optValue > bytes.length) {
if (optValue !== undefined && optValue > bytes.length) {
var addingZeros = new Array(optValue-bytes.length).fill(0);
bytes = addingZeros.concat(bytes);
}
@@ -89,7 +89,7 @@ wycheproof.BigInteger.prototype.toBase64Url = function(optValue) {
*/
wycheproof.BigInteger.prototype.toArrayBuffer = function(optValue) {
var bytes = this.toByteArray();
if (goog.isDef(optValue) && optValue > bytes.length) {
if (optValue !== undefined && optValue > bytes.length) {
var addingZeros = new Array(optValue-bytes.length).fill(0);
bytes = addingZeros.concat(bytes);
}