319 lines
13 KiB
Python
319 lines
13 KiB
Python
import unittest
|
|
|
|
from fastapi import HTTPException
|
|
from fastapi.testclient import TestClient
|
|
|
|
from app.api.review_rules import get_audit_log_service, get_review_rule_service, require_current_user
|
|
from app.main import app
|
|
|
|
|
|
class StubAuditLogService:
|
|
def __init__(self):
|
|
self.events = []
|
|
|
|
def record_event(self, **kwargs):
|
|
self.events.append(kwargs)
|
|
return kwargs
|
|
|
|
|
|
class StubReviewRuleService:
|
|
def list_rules(self, current_user, page, page_size):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
return {
|
|
"items": [
|
|
{
|
|
"id": "rule-123",
|
|
"name": "自动续约预警",
|
|
"rule_code": "RULE-AUTO-RENEWAL-001",
|
|
"keyword": "自动续约",
|
|
"contract_type": "all",
|
|
"risk_level": "high",
|
|
"description": "建议补充通知期限和终止条件。",
|
|
"suggestion": "补充通知期限。",
|
|
"legal_basis": "《民法典》相关规则。",
|
|
"is_active": True,
|
|
"published_at": None,
|
|
"published_by": None,
|
|
"latest_governance_asset_id": None,
|
|
"current_version_label": "v1.0",
|
|
"latest_change_summary": "Initial rule version",
|
|
"latest_version_created_at": "2026-04-16T00:00:00+00:00",
|
|
"version_count": 1,
|
|
"created_at": "2026-04-16T00:00:00+00:00",
|
|
"updated_at": "2026-04-16T00:00:00+00:00",
|
|
}
|
|
],
|
|
"page": page,
|
|
"page_size": page_size,
|
|
"total": 1,
|
|
}
|
|
|
|
def create_rule(self, current_user, name, keyword, contract_type, risk_level, description, suggestion, legal_basis, is_active, rule_code=None):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
return {
|
|
"id": "rule-123",
|
|
"name": name,
|
|
"rule_code": rule_code or "RULE-PAYMENT-MILESTONE-001",
|
|
"keyword": keyword,
|
|
"contract_type": contract_type,
|
|
"risk_level": risk_level,
|
|
"description": description,
|
|
"suggestion": suggestion,
|
|
"legal_basis": legal_basis,
|
|
"is_active": is_active,
|
|
"published_at": None,
|
|
"published_by": None,
|
|
"latest_governance_asset_id": None,
|
|
"current_version_label": "v1.0",
|
|
"latest_change_summary": "Initial rule version",
|
|
"latest_version_created_at": "2026-04-16T00:00:00+00:00",
|
|
"version_count": 1,
|
|
"created_at": "2026-04-16T00:00:00+00:00",
|
|
"updated_at": "2026-04-16T00:00:00+00:00",
|
|
}
|
|
|
|
def update_rule(self, current_user, rule_id, name, keyword, contract_type, risk_level, description, suggestion, legal_basis, is_active, rule_code=None):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
return {
|
|
"id": rule_id,
|
|
"name": name,
|
|
"rule_code": rule_code or "RULE-PAYMENT-MILESTONE-001",
|
|
"keyword": keyword,
|
|
"contract_type": contract_type,
|
|
"risk_level": risk_level,
|
|
"description": description,
|
|
"suggestion": suggestion,
|
|
"legal_basis": legal_basis,
|
|
"is_active": is_active,
|
|
"published_at": None,
|
|
"published_by": None,
|
|
"latest_governance_asset_id": None,
|
|
"current_version_label": "v1.1",
|
|
"latest_change_summary": "v1.1 rule update",
|
|
"latest_version_created_at": "2026-04-16T00:00:00+00:00",
|
|
"version_count": 2,
|
|
"created_at": "2026-04-16T00:00:00+00:00",
|
|
"updated_at": "2026-04-16T00:00:00+00:00",
|
|
}
|
|
|
|
def update_rule_status(self, current_user, rule_id, is_active):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
return {
|
|
"id": rule_id,
|
|
"name": "自动续约预警",
|
|
"rule_code": "RULE-AUTO-RENEWAL-001",
|
|
"keyword": "自动续约",
|
|
"contract_type": "all",
|
|
"risk_level": "high",
|
|
"description": "建议补充通知期限和终止条件。",
|
|
"suggestion": "补充通知期限。",
|
|
"legal_basis": "《民法典》相关规则。",
|
|
"is_active": is_active,
|
|
"published_at": None,
|
|
"published_by": None,
|
|
"latest_governance_asset_id": None,
|
|
"current_version_label": "v1.0",
|
|
"latest_change_summary": "Initial rule version",
|
|
"latest_version_created_at": "2026-04-16T00:00:00+00:00",
|
|
"version_count": 1,
|
|
"created_at": "2026-04-16T00:00:00+00:00",
|
|
"updated_at": "2026-04-16T00:00:00+00:00",
|
|
}
|
|
|
|
def publish_rule(self, current_user, rule_id):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
result = self.update_rule_status(current_user, rule_id, True)
|
|
result["published_at"] = "2026-05-13T09:00:00+00:00"
|
|
result["published_by"] = current_user["id"]
|
|
result["latest_governance_asset_id"] = "govast-rule-123"
|
|
return result
|
|
|
|
def unpublish_rule(self, current_user, rule_id):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
result = self.update_rule_status(current_user, rule_id, False)
|
|
result["published_at"] = None
|
|
result["published_by"] = None
|
|
result["latest_governance_asset_id"] = None
|
|
return result
|
|
|
|
def rollback_rule(self, current_user, rule_id, target_version_label, change_summary=None):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
result = self.unpublish_rule(current_user, rule_id)
|
|
result["current_version_label"] = "v1.2"
|
|
result["latest_change_summary"] = change_summary or f"Rollback to {target_version_label}"
|
|
result["version_count"] = 3
|
|
return result
|
|
|
|
def delete_rule(self, current_user, rule_id):
|
|
if current_user["role"] != "admin":
|
|
raise HTTPException(status_code=403, detail="forbidden")
|
|
return {
|
|
"id": rule_id,
|
|
"name": "自动续约预警",
|
|
"keyword": "自动续约",
|
|
"contract_type": "all",
|
|
"risk_level": "high",
|
|
"description": "建议补充通知期限和终止条件。",
|
|
"suggestion": "补充通知期限。",
|
|
"legal_basis": "《民法典》相关规则。",
|
|
"is_active": True,
|
|
"created_at": "2026-04-16T00:00:00+00:00",
|
|
"updated_at": "2026-04-16T00:00:00+00:00",
|
|
}
|
|
|
|
|
|
class ReviewRulesApiTestCase(unittest.TestCase):
|
|
def setUp(self):
|
|
self.audit_log_service = StubAuditLogService()
|
|
app.dependency_overrides[get_review_rule_service] = lambda: StubReviewRuleService()
|
|
app.dependency_overrides[get_audit_log_service] = lambda: self.audit_log_service
|
|
self.client = TestClient(app)
|
|
|
|
def tearDown(self):
|
|
app.dependency_overrides.clear()
|
|
|
|
def test_admin_can_list_review_rules(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-admin",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "admin",
|
|
}
|
|
|
|
response = self.client.get("/api/v1/review-rules")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(response.json()["data"]["items"][0]["name"], "自动续约预警")
|
|
self.assertEqual(response.json()["data"]["items"][0]["rule_code"], "RULE-AUTO-RENEWAL-001")
|
|
|
|
def test_admin_can_create_review_rule(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-admin",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "admin",
|
|
}
|
|
|
|
response = self.client.post(
|
|
"/api/v1/review-rules",
|
|
data={
|
|
"name": "付款节点预警",
|
|
"keyword": "付款",
|
|
"contract_type": "procurement",
|
|
"risk_level": "medium",
|
|
"description": "需要明确付款节点。",
|
|
"suggestion": "补充验收和发票条件。",
|
|
"legal_basis": "《民法典》价款支付规则。",
|
|
"is_active": "true",
|
|
},
|
|
)
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(response.json()["data"]["keyword"], "付款")
|
|
self.assertEqual(self.audit_log_service.events[0]["action"], "create_review_rule")
|
|
self.assertEqual(
|
|
self.audit_log_service.events[0]["detail_json"],
|
|
{
|
|
"name": "付款节点预警",
|
|
"rule_code": "RULE-PAYMENT-MILESTONE-001",
|
|
"keyword": "付款",
|
|
"contract_type": "procurement",
|
|
"risk_level": "medium",
|
|
"is_active": True,
|
|
},
|
|
)
|
|
|
|
def test_admin_can_update_review_rule_status(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-admin",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "admin",
|
|
}
|
|
|
|
response = self.client.patch("/api/v1/review-rules/rule-123/status", data={"is_active": "false"})
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertFalse(response.json()["data"]["is_active"])
|
|
self.assertEqual(self.audit_log_service.events[0]["action"], "update_review_rule_status")
|
|
self.assertEqual(
|
|
self.audit_log_service.events[0]["detail_json"],
|
|
{"name": "自动续约预警", "keyword": "自动续约", "is_active": False},
|
|
)
|
|
|
|
def test_member_cannot_access_review_rules(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-member",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "member",
|
|
}
|
|
|
|
response = self.client.get("/api/v1/review-rules")
|
|
|
|
self.assertEqual(response.status_code, 403)
|
|
self.assertEqual(response.json()["message"], "forbidden")
|
|
|
|
def test_admin_can_delete_review_rule(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-admin",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "admin",
|
|
}
|
|
|
|
response = self.client.delete("/api/v1/review-rules/rule-123")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(response.json()["data"]["id"], "rule-123")
|
|
self.assertEqual(self.audit_log_service.events[0]["action"], "delete_review_rule")
|
|
self.assertEqual(
|
|
self.audit_log_service.events[0]["detail_json"],
|
|
{
|
|
"name": "自动续约预警",
|
|
"keyword": "自动续约",
|
|
"contract_type": "all",
|
|
"risk_level": "high",
|
|
"is_active": True,
|
|
},
|
|
)
|
|
|
|
def test_admin_can_publish_unpublish_and_rollback_review_rule(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-admin",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "admin",
|
|
}
|
|
|
|
publish_response = self.client.post("/api/v1/review-rules/rule-123/publish")
|
|
unpublish_response = self.client.post("/api/v1/review-rules/rule-123/unpublish")
|
|
rollback_response = self.client.post("/api/v1/review-rules/rule-123/rollback", data={"target_version_label": "v1.0"})
|
|
|
|
self.assertEqual(publish_response.status_code, 200)
|
|
self.assertEqual(unpublish_response.status_code, 200)
|
|
self.assertEqual(rollback_response.status_code, 200)
|
|
self.assertEqual(publish_response.json()["data"]["published_by"], "user-admin")
|
|
self.assertEqual(unpublish_response.json()["data"]["published_at"], None)
|
|
self.assertEqual(rollback_response.json()["data"]["current_version_label"], "v1.2")
|
|
self.assertEqual(self.audit_log_service.events[-3]["action"], "publish_review_rule")
|
|
self.assertEqual(self.audit_log_service.events[-2]["action"], "unpublish_review_rule")
|
|
self.assertEqual(self.audit_log_service.events[-1]["action"], "rollback_review_rule")
|
|
|
|
def test_member_cannot_delete_review_rule(self):
|
|
app.dependency_overrides[require_current_user] = lambda: {
|
|
"id": "user-member",
|
|
"tenant_id": "tenant-demo-001",
|
|
"role": "member",
|
|
}
|
|
|
|
response = self.client.delete("/api/v1/review-rules/rule-123")
|
|
|
|
self.assertEqual(response.status_code, 403)
|
|
self.assertEqual(response.json()["message"], "forbidden")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|